Update list system settings schema #50
Conversation
|
list_system_settings_schema seems not consist for settings with boolean value. For other settings, list_system_settings_schema will return all valid values for that settings. For boolean settings, it will return true or false, and currently the value is used to check if this setting is supported. It's not like other settings that checking if the value is empty. If changed boolean to array, these settings could also return all supported values (normally true and false) like the other settings. And it can also return empty list as not supported just as the other settings do. This PR includes commit from my previous PR as I think it would be easy to merge this if my previous PR is merged. I can separate them if needed. |
System settings support enable / disable should also return all valid values like other settings. Change boolean to array and the array contains boolean value (true for enable and false for disable). Can set array to empty if the settings don't support to be set.
zhao-gang
force-pushed
the
update-list-system-settings-schema
branch
from
285a7c7 to
97c87cd
Compare
|
Hi Zhao, There is an issue with doing this. I understand this is a good way to reflect what's supported and what's not. But it does not reflect the spec correctly. We will need to change the spec first before changing the compliance suite. Can you make a PR there first? |
This pull request depends on #49Do not depend on other PR so it's better to review this.